]> git.ipfire.org Git - thirdparty/git.git/commit - xdiff/xprepare.c
diff histogram: intern strings
authorPhillip Wood <phillip.wood@dunelm.org.uk>
Wed, 17 Nov 2021 11:20:23 +0000 (11:20 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 19 Nov 2021 06:23:31 +0000 (22:23 -0800)
commit663c5ad0356f5501e2db7a39a7abf76e8db26b7d
tree4a8a5e3298dd98cdb1e2c89dd90d6f6334b781b9
parentcd3e606211bb1cf8bc57f7d76bab98cc17a150bc
diff histogram: intern strings

Histogram is the only diff algorithm not to call
xdl_classify_record(). xdl_classify_record() ensures that the hash
values of two strings that are not equal differ which means that it is
not necessary to use xdl_recmatch() when comparing lines, all that is
necessary is to compare the hash values. This gives a 7% reduction in
the runtime of "git log --patch" when using the histogram diff
algorithm.

Test                                  HEAD^             HEAD
-----------------------------------------------------------------------------
4000.1: log -3000 (baseline)          0.18(0.14+0.04)   0.19(0.17+0.02) +5.6%
4000.2: log --raw -3000 (tree-only)   0.99(0.77+0.21)   0.98(0.78+0.20) -1.0%
4000.3: log -p -3000 (Myers)          4.84(4.31+0.51)   4.81(4.15+0.64) -0.6%
4000.4: log -p -3000 --histogram      6.34(5.86+0.46)   5.87(5.19+0.66) -7.4%
4000.5: log -p -3000 --patience       5.39(4.60+0.76)   5.35(4.60+0.73) -0.7%

Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
xdiff/xhistogram.c
xdiff/xprepare.c