]> git.ipfire.org Git - thirdparty/git.git/commit
MyFirstContribution: refrain from self-iterating too much
authorJunio C Hamano <gitster@pobox.com>
Fri, 28 Jul 2023 00:43:17 +0000 (17:43 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 28 Jul 2023 00:44:07 +0000 (17:44 -0700)
commit010447cf098f7407008f2940b4fefa5351477044
tree50ff041f7e1fc04b51b89dfdfe507632f1daf67f
parent844ede312b4e988881b6e27e352f469d8ab80b2a
MyFirstContribution: refrain from self-iterating too much

Finding mistakes in and improving your own patches is a good idea,
but doing so too quickly is being inconsiderate to reviewers who
have just seen the initial iteration and taking their time to review
it.  Encourage new developers to perform such a self review before
they send out their patches, not after.  After sending a patch that
they immediately found mistakes in, they are welcome to comment on
them, mentioning what and how they plan to improve them in an
updated version, before sending out their updates.

Helped-by: Torsten Bögershausen <tboegi@web.de>
Helped-by: Linus Arver <linusa@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/MyFirstContribution.txt