]> git.ipfire.org Git - thirdparty/openssl.git/commit
Remove create_empty_fragment from do_dtls1_write()
authorMatt Caswell <matt@openssl.org>
Thu, 6 Oct 2022 12:18:43 +0000 (13:18 +0100)
committerMatt Caswell <matt@openssl.org>
Thu, 20 Oct 2022 13:39:32 +0000 (14:39 +0100)
commit22d6e8547f11dae2e4c026be93331e9acfe9b940
tree35b578f262f1c02c7d2d1810bffd188a52359b42
parent706fc5f6ebd63e1fcd18d4764248206ab3c18a0a
Remove create_empty_fragment from do_dtls1_write()

do_dtls1_write() was never called with a value for create_empty_fragment
that was ever non-zero - so this is dead code and can be removed. The
equivalent code in the TLS processing is used for TLS1.0/SSLv3 to protect
against known IV weaknesses because those protocol versions do not have
an explicit IV. However DTLS1.0 is based on TLSv1.1 and *does* have an
explicit IV - so this is not useful there.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19424)
ssl/d1_msg.c
ssl/record/rec_layer_d1.c
ssl/record/record.h