]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Preparing for better signal handling: some code refactoring
authorSelva Nair <selva.nair@gmail.com>
Sun, 1 Jan 2023 21:51:05 +0000 (16:51 -0500)
committerGert Doering <gert@greenie.muc.de>
Thu, 5 Jan 2023 14:19:39 +0000 (15:19 +0100)
commit264ce74c409018f42b178ba2cab544bdcecb1767
tree68f3e58335cab979f00b9c239c79ea976d133443
parente47c88bbc593f99529712229fae65470a2e4e0a8
Preparing for better signal handling: some code refactoring

- Do not directly update signal_received: always use register_signal()
  throw_signal() or signal_reset().
  To facilitate this, register_signal() now takes c->sig as an argument
  instead of the context c itself, and sig_info struct is passed-in to
  functions that need to set a signal.

- openvpn_getaddrinfo() is updated in a following commit as it
  could benefit from some logic changes that we may or may not want
  to do.

No functional changes.

TODO:
(i)   update signal handling in openvpn_getaddrinfo
(ii)  enforce signal priority
(iii) fix signal handling on Windows
for 2.7?
(iv)  replace system-V signal with POSIX sigaction

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230101215109.1521549-2-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25874.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 05715485b45816e18b52ffb9b47ca22a55abb334)
16 files changed:
src/openvpn/dco_win.c
src/openvpn/dco_win.h
src/openvpn/forward.c
src/openvpn/init.c
src/openvpn/multi.c
src/openvpn/occ.c
src/openvpn/ping.c
src/openvpn/proxy.c
src/openvpn/proxy.h
src/openvpn/push.c
src/openvpn/sig.c
src/openvpn/sig.h
src/openvpn/socket.c
src/openvpn/socks.c
src/openvpn/socks.h
src/openvpn/win32.c