]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
[gdb] Fix -Wstrict-null-sentinel warning (--with-iconv-bin)
authorTom de Vries <tdevries@suse.de>
Wed, 12 Feb 2020 10:15:33 +0000 (11:15 +0100)
committerTom de Vries <tdevries@suse.de>
Wed, 12 Feb 2020 10:15:33 +0000 (11:15 +0100)
commit38de8abe21fe17c31888094bd860a84f88cb5749
tree43a649e2fcb5e7043286e14cd7171308802a41a7
parent9706160abd7dd2137359e4575b25ef49dfdaad0c
[gdb] Fix -Wstrict-null-sentinel warning (--with-iconv-bin)

When using configure flag --with-iconv-bin=$(which iconv), we run into:
...
gdb/charset.c: In function 'void find_charset_names()':
gdb/charset.c:821:75: error: missing sentinel in function call [-Werror=format=]
     iconv_program = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", NULL);
                                                                           ^
cc1plus: all warnings being treated as errors
...

Fix the warning.

Build and reg-tested on x86_64-linux.

2020-02-12  Lukas Durfina  <ldurfina@tachyum.com>
    Tom de Vries  <tdevries@suse.de>

* charset.c (find_charset_names): Cast concat NULL sentinel to char *.
gdb/charset.c