]> git.ipfire.org Git - thirdparty/git.git/commit
lazyload: use correct calling conventions
authorMatthias Aßhauer <mha1993@live.de>
Sat, 8 Jan 2022 16:02:30 +0000 (16:02 +0000)
committerJunio C Hamano <gitster@pobox.com>
Sun, 9 Jan 2022 18:34:53 +0000 (10:34 -0800)
commit4a9b204920152c668228a9d43a63be39b0c32f45
tree72622ac8970e285d3eb6ebe1350e25741a604f5a
parente9d7761bb94f20acc98824275e317fa82436c25d
lazyload: use correct calling conventions

Christoph Reiter reported on the Git for Windows issue tracker[1], that
mingw_strftime() imports strftime() from ucrtbase.dll with the wrong
calling convention. It should be __cdecl instead of WINAPI, which we
always use in DECLARE_PROC_ADDR().

The MSYS2 project encountered cmake sefaults on x86 Windows caused by
the same issue in the cmake source. [2] There are no known git crashes
that where caused by this, yet, but we should try to prevent them.

We import two other non-WINAPI functions via DECLARE_PROC_ADDR(), too.

* NtSetSystemInformation() (NTAPI)
* GetUserNameExW()         (SEC_ENTRY)

NTAPI, SEC_ENTRY and WINAPI are all ususally defined as __stdcall,
but there are circumstances where they're defined differently.

Teach DECLARE_PROC_ADDR() about calling conventions and be explicit
about when we want to use which calling convention.

Import winnt.h for the definition of NTAPI and sspi.h for SEC_ENTRY
near their respective only users.

[1] https://github.com/git-for-windows/git/issues/3560
[2] https://github.com/msys2/MINGW-packages/issues/10152

Reported-By: Christoph Reiter <reiter.christoph@gmail.com>
Signed-off-by: Matthias Aßhauer <mha1993@live.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/mingw.c
compat/win32/lazyload.h
compat/win32/trace2_win32_process_info.c
compat/winansi.c
t/helper/test-drop-caches.c