]> git.ipfire.org Git - thirdparty/systemd.git/commit
Revert "resolved: address DVE-2018-0001"
authorDimitri John Ledkov <dimitri.ledkov@canonical.com>
Thu, 30 Mar 2023 20:58:40 +0000 (21:58 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Thu, 18 May 2023 11:20:12 +0000 (12:20 +0100)
commit4aa37ad301bc98ea383e07e72ba711215c723b11
treeb0e17aabfa3f1060eaa74e7075c199578a7fc78b
parentcb4e5d51553172aa72f432651fb78b70a30acb33
Revert "resolved: address DVE-2018-0001"

DVE-2018-0001 has been fixed by the vendor, and this workaround is no longer
needed. Removal of this workaround improves performance as queries used to be
retried more than necessory.

This reverts 1ed4e584f3a03f47d2313314b6b5a78c9dc6f135.
This reverts https://github.com/systemd/systemd/pull/18638

Keep .clamp_feature_level_servfail name, as imho it is more descriptive than
just .clamp_feature_level, especially if we ever need to add similar
workarounds as the one we had for DVE-2018-0001.

However note that there is another retry which was added in
8a33aa199dc1cea14494469ac9d7d08dc6721df1 - seems to be working around Stubby
resolver behaviour.

Fixes: #26967
src/resolve/resolved-dns-transaction.c
src/resolve/resolved-dns-transaction.h