]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: Fix handling of XFR requests over DoH 14156/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 23 Apr 2024 13:28:14 +0000 (15:28 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 13 May 2024 07:47:05 +0000 (09:47 +0200)
commit5d4d8e2281c2fcd08aa7e5a3a290943ff8d52f08
tree9e4f568a41814aa215ba553f46324dab05138be0
parentf3b5893acfc888c89fe5793ce902120ee0cc527a
dnsdist: Fix handling of XFR requests over DoH

We did not properly handle incoming XFR requests received over DoH
When a TCP-only or DoT backend was configured, and the nghttp2 provider
used.
This commits fixes the assertion failure and makes sure that XFR
requests are denied with `NOTIMP` when received over DNS over HTTPS,
including DNS over HTTP/3. It also denies them when received over
DNS over QUIC as this is not properly handled at the moment, although
it does not cause a crash.
pdns/dnsdistdist/dnsdist-idstate.cc
pdns/dnsdistdist/dnsdist-nghttp2-in.cc
pdns/dnsdistdist/dnsdist.cc
regression-tests.dnsdist/quictests.py
regression-tests.dnsdist/test_DOH.py
regression-tests.dnsdist/test_DOH3.py
regression-tests.dnsdist/test_DOQ.py