]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Don't use print_insn_XXX in GDB
authorYao Qi <yao.qi@linaro.org>
Wed, 14 Jun 2017 15:28:30 +0000 (16:28 +0100)
committerYao Qi <yao.qi@linaro.org>
Wed, 14 Jun 2017 15:29:01 +0000 (16:29 +0100)
commit6394c606997f88acfc80de4dff33a4ae2de987b4
tree5b5a471c54f93ab62d4875deecd1f34f8a3a67b8
parent99031bafd6e81a41553803886c6b245cb0ab89d9
Don't use print_insn_XXX in GDB

This is a follow-up to

  [PATCH 0/6] Unify the disassembler selection in gdb and objdump
  https://sourceware.org/ml/binutils/2017-05/msg00192.html

that is, opcodes is able to select the right disassembler, so gdb
doesn't have to select them.  Instead, gdb can just use
default_print_insn.  As a result, these print_insn_XXX are not used
out of opcodes, so this patch also moves their declarations from
include/dis-asm.h to opcodes/disassemble.h.  With this change,
GDB doesn't use any print_insn_XXX directly any more.

gdb:

2017-06-14  Yao Qi  <yao.qi@linaro.org>

* aarch64-tdep.c (aarch64_gdb_print_insn): Call
default_print_insn instead of print_insn_aarch64.
* arm-tdep.c (gdb_print_insn_arm): Call
default_print_insn instead of print_insn_big_arm
and print_insn_little_arm.
* i386-tdep.c (i386_print_insn): Call default_print_insn
instead of print_insn_i386.
* ia64-tdep.c (ia64_print_insn): Call
default_print_insn instead of print_insn_ia64.
* mips-tdep.c (gdb_print_insn_mips): Call
default_print_insn instead of print_insn_big_mips
and print_insn_little_mips.
* spu-tdep.c (gdb_print_insn_spu): Call default_print_insn
instead of print_insn_spu.

include:

2017-06-14  Yao Qi  <yao.qi@linaro.org>

* dis-asm.h (print_insn_aarch64): Move it to opcodes/disassemble.h.
(print_insn_big_arm, print_insn_big_mips): Likewise.
(print_insn_i386, print_insn_ia64): Likewise.
(print_insn_little_arm, print_insn_little_mips): Likewise.
(print_insn_spu): Likewise.

opcodes:

2017-06-14  Yao Qi  <yao.qi@linaro.org>

* aarch64-dis.c: Include disassemble.h instead of dis-asm.h.
* arm-dis.c: Likewise.
* ia64-dis.c: Likewise.
* mips-dis.c: Likewise.
* spu-dis.c: Likewise.
* disassemble.h (print_insn_aarch64): New declaration, moved from
include/dis-asm.h.
(print_insn_big_arm, print_insn_big_mips): Likewise.
(print_insn_i386, print_insn_ia64): Likewise.
(print_insn_little_arm, print_insn_little_mips): Likewise.
16 files changed:
gdb/ChangeLog
gdb/aarch64-tdep.c
gdb/arm-tdep.c
gdb/i386-tdep.c
gdb/ia64-tdep.c
gdb/mips-tdep.c
gdb/spu-tdep.c
include/ChangeLog
include/dis-asm.h
opcodes/ChangeLog
opcodes/aarch64-dis.c
opcodes/arm-dis.c
opcodes/disassemble.h
opcodes/ia64-dis.c
opcodes/mips-dis.c
opcodes/spu-dis.c