]> git.ipfire.org Git - thirdparty/git.git/commit
merge-recursive: fix logic ordering issue
authorElijah Newren <newren@gmail.com>
Fri, 5 Jan 2018 20:20:00 +0000 (12:20 -0800)
committerJunio C Hamano <gitster@pobox.com>
Fri, 19 Jan 2018 22:44:18 +0000 (14:44 -0800)
commit6c8647da5c84bac9039135652ce5e4beb763e5be
tree27e2a3d0e42968877bb4859d166fa8345e6cc6a6
parent7c5585ff488638a3754368f090ad6b6576c6714b
merge-recursive: fix logic ordering issue

merge_trees() did a variety of work, including:
  * Calling get_unmerged() to get unmerged entries
  * Calling record_df_conflict_files() with all unmerged entries to
    do some work to ensure we could handle D/F conflicts correctly
  * Calling get_renames() to check for renames.

An easily overlooked issue is that get_renames() can create more
unmerged entries and add them to the list, which have the possibility of
being involved in D/F conflicts.  So the call to
record_df_conflict_files() should really be moved after all the rename
detection.  I didn't come up with any testcases demonstrating any bugs
with the old ordering, but I suspect there were some for both normal
renames and for directory renames.  Fix the ordering.

Reviewed-By: Stefan Beller <sbeller@google.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-recursive.c