]> git.ipfire.org Git - thirdparty/git.git/commit
shortlog: fix segfault on empty authorname
authorJunio C Hamano <junkio@cox.net>
Sun, 10 Dec 2006 23:51:54 +0000 (15:51 -0800)
committerJunio C Hamano <junkio@cox.net>
Mon, 11 Dec 2006 22:12:33 +0000 (14:12 -0800)
commit6f9872582246b9b8ee4bdc9f6a563b409aab1ecb
tree682423816c502753915b167166f14855d6363a24
parentbca73251da5cc3e4bea71e28e0096a5cd662bbd9
shortlog: fix segfault on empty authorname

The old code looked backwards from the email address to parse
the name, allowing an arbitrary number of spaces between the
two. However, in the case of no name, we looked back too far to
the 'author' (or 'Author:') header.

The bug was triggered by commit febf7ea4bed from linux-2.6.

Jeff King originally fixed it by looking back only one
character; Johannes Schindelin pointed out that we could try
harder while at it to cope with commits with broken headers.

Signed-off-by: Junio C Hamano <junkio@cox.net>
builtin-shortlog.c