]> git.ipfire.org Git - thirdparty/git.git/commit
diff-lib: tighten show_interdiff()'s interface
authorEric Sunshine <sunshine@sunshineco.com>
Tue, 8 Sep 2020 07:16:09 +0000 (03:16 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 8 Sep 2020 22:03:27 +0000 (15:03 -0700)
commit72a7239016fa4c8919a8b6932ad76e5f820389eb
tree6fe239c7b77ee41d542fb7b3740cde862cd4eca3
parentcdffbdc217aba8a39d786a642d1376a5a605adec
diff-lib: tighten show_interdiff()'s interface

To compute and show an interdiff, show_interdiff() needs only the two
OID's to compare and a diffopts, yet it expects callers to supply an
entire rev_info. The demand for rev_info is not only overkill, but also
places unnecessary burden on potential future callers which might not
otherwise have a rev_info at hand. Address this by tightening its
signature to require only the items it needs instead of a full rev_info.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/log.c
diff-lib.c
diff.h
log-tree.c