]> git.ipfire.org Git - thirdparty/git.git/commit
git-gui--askpass: coerce answers to UTF-8 on Windows
authorLuke Bonanomi <lbonanomi@gmail.com>
Thu, 12 Mar 2020 21:31:50 +0000 (21:31 +0000)
committerPratyush Yadav <me@yadavpratyush.com>
Sat, 14 Mar 2020 17:16:40 +0000 (22:46 +0530)
commit850cf9ae961ce59c980b0c59abd3dd676fb7b7ec
treed272db6a57243cb809379028c3829c1abd743eb3
parentd769dcc5cdd92e046eadee3cf878afc7ca806b14
git-gui--askpass: coerce answers to UTF-8 on Windows

This addresses the issue where Git for Windows asks the user for a
password, no credential helper is available, and then Git fails to pick
up non-ASCII characters from the Git GUI helper.

This can be verified e.g. via

echo host=http://abc.com |
git -c credential.helper= credential fill

and then pasting some umlauts.

The underlying reason is that Git for Windows tries to communicate using
the UTF-8 encoding no matter what the actual current code page is. So
let's indulge Git for Windows and do use that encoding.

This fixes https://github.com/git-for-windows/git/issues/2215

Signed-off-by: Luke Bonanomi <lbonanomi@gmail.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
git-gui--askpass