]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdbarch_breakpoint_from_pc doesn't return NULL
authorYao Qi <yao.qi@linaro.org>
Thu, 3 Nov 2016 14:35:13 +0000 (14:35 +0000)
committerYao Qi <yao.qi@linaro.org>
Thu, 3 Nov 2016 14:35:13 +0000 (14:35 +0000)
commit8b55a7e4e5b30877e924e4b0ed0437d16ccdcedf
treec1a849b865baaab7c8c31ae9545a1eac2321ca81
parentbada43421274615d0d5f629a61a60b7daa71bc15
gdbarch_breakpoint_from_pc doesn't return NULL

gdbarch_breakpoint_from_pc doesn't return NULL except for
ia64_breakpoint_from_pc, and we checked its return value in three
places. In microblaze_linux_memory_remove_breakpoint and
ppc_linux_memory_remove_breakpoint, gdbarch_breakpoint_from_pc never
returns NULL, so we can remove the NULL checking.  In
default_memory_insert_breakpoint, gdbarch_breakpoint_from_pc can't
returns NULL too because ia64 defines its own memory_insert_breakpoint.

gdb:

2016-11-03  Yao Qi  <yao.qi@linaro.org>

* mem-break.c (default_memory_insert_breakpoint): Don't check
'bp' against NULL.
* microblaze-linux-tdep.c (microblaze_linux_memory_remove_breakpoint):
Likewise.
* ppc-linux-tdep.c (ppc_linux_memory_remove_breakpoint): Likewise.
gdb/ChangeLog
gdb/mem-break.c
gdb/microblaze-linux-tdep.c
gdb/ppc-linux-tdep.c