]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb: use intrusive list for step-over chain
authorSimon Marchi <simon.marchi@polymtl.ca>
Tue, 15 Jun 2021 18:49:32 +0000 (14:49 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Tue, 13 Jul 2021 00:46:52 +0000 (20:46 -0400)
commit8b6a69b2f37fd1370aa823320f9dc3fd482e1e78
treeaadd270b49270314c5c60f4e25ae1dd6ce74c9a4
parent08bdefb58b78621f50b30f64170e2cdc31c1b2cf
gdb: use intrusive list for step-over chain

The threads that need a step-over are currently linked using an
hand-written intrusive doubly-linked list, so that seems a very good
candidate for intrusive_list, convert it.

For this, we have a use case of appending a list to another one (in
start_step_over).  Based on the std::list and Boost APIs, add a splice
method.  However, only support splicing the other list at the end of the
`this` list, since that's all we need.

Add explicit default assignment operators to
reference_to_pointer_iterator, which are otherwise implicitly deleted.
This is needed because to define thread_step_over_list_safe_iterator, we
wrap reference_to_pointer_iterator inside a basic_safe_iterator, and
basic_safe_iterator needs to be able to copy-assign the wrapped
iterator.  The move-assignment operator is therefore not needed, only
the copy-assignment operator is.  But for completeness, add both.

Change-Id: I31b2ff67c7b78251314646b31887ef1dfebe510c
gdb/gdbthread.h
gdb/infrun.c
gdb/infrun.h
gdb/thread.c
gdb/unittests/intrusive_list-selftests.c
gdbsupport/intrusive_list.h
gdbsupport/reference-to-pointer-iterator.h