]> git.ipfire.org Git - thirdparty/git.git/commit
advice.h: add missing __attribute__((format)) & fix usage
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 13 Jul 2021 08:05:20 +0000 (10:05 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 13 Jul 2021 22:20:20 +0000 (15:20 -0700)
commit927dc33070563d6646c903daf919dde80d8878d4
tree6c5642e618a93255ef47be55b403160a12da999c
parent75d31ceec5870c94c934264b7a9afe029b787410
advice.h: add missing __attribute__((format)) & fix usage

Add the missing __attribute__((format)) checking to
advise_if_enabled(). This revealed a trivial issue introduced in
b3b18d16213 (advice: revamp advise API, 2020-03-02). We treated the
argv[1] as a format string, but did not intend to do so. Let's use
"%s" and pass argv[1] as an argument instead.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
advice.h
t/helper/test-advise.c