]> git.ipfire.org Git - thirdparty/mdadm.git/commit
imsm: block changing slots during creation
authorMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Mon, 20 Jun 2022 16:10:43 +0000 (00:10 +0800)
committerJes Sorensen <jsorensen@fb.com>
Fri, 24 Jun 2022 17:56:27 +0000 (13:56 -0400)
commit9a7df595bbe360132cb37c8b39aa1fd9ac24b43f
tree2d904190610307e381e2b243e91afe2c5556e43d
parent6d4d9ab295de165e57b5c30e044028dbffb8f297
imsm: block changing slots during creation

If user specifies drives for array creation, then slot order across
volumes is not preserved.
Ideally, it should be checked in validate_geometry() but it is not
possible in current implementation (order is determined later).
Add verification in add_to_super_imsm_volume() and throw error if
mismatch is detected.
IMSM allows to use only same members within container.
This is not hardware dependency but metadata limitation.
Therefore, 09-imsm-overlap test is removed. Testing it is pointless.
After this patch, creation in this scenario is blocked. Offset
verification is covered in other tests.

Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Acked-by: Coly Li <colyli@suse.de>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
super-intel.c
tests/09imsm-overlap [deleted file]