]> git.ipfire.org Git - thirdparty/qemu.git/commit
ui/vnc-clipboard: fix inflate_buffer
authorFiona Ebner <f.ebner@proxmox.com>
Wed, 22 Nov 2023 12:58:26 +0000 (13:58 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 20 Dec 2023 16:11:10 +0000 (19:11 +0300)
commitaada709c26f601a1973d2c1f9880f91dfe75f195
tree5fe57145b69b186618a2c321c7279fc40629b084
parent591618f27be402c80a241569565c2ecc344c0746
ui/vnc-clipboard: fix inflate_buffer

Commit d921fea338 ("ui/vnc-clipboard: fix infinite loop in
inflate_buffer (CVE-2023-3255)") removed this hunk, but it is still
required, because it can happen that stream.avail_in becomes zero
before coming across a return value of Z_STREAM_END in the loop.

This fixes the host->guest direction of the clipboard with noVNC and
TigerVNC as clients.

Fixes: d921fea338 ("ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)")
Reported-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231122125826.228189-1-f.ebner@proxmox.com>
(cherry picked from commit ebfbf394671163c14e2b24d98f3927a3151d1aff)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
ui/vnc-clipboard.c