]> git.ipfire.org Git - thirdparty/gcc.git/commit
i386: Don't emit pushf;pop for __builtin_ia32_readeflags_u* with unused lhs [PR104971]
authorJakub Jelinek <jakub@redhat.com>
Sat, 19 Mar 2022 12:53:12 +0000 (13:53 +0100)
committerJakub Jelinek <jakub@redhat.com>
Sat, 19 Mar 2022 12:53:12 +0000 (13:53 +0100)
commitb60bc913cca7439d29a7ec9e9a7f448d8841b43c
treea615a4eed338252dc3952782ddc6ce65855f290e
parent2663d18356b0a62f5a800c7e5596d814cd3c2c41
i386: Don't emit pushf;pop for __builtin_ia32_readeflags_u* with unused lhs [PR104971]

__builtin_ia32_readeflags_u* aren't marked const or pure I think
intentionally, so that they aren't CSEd from different regions of a function
etc. because we don't and can't easily track all dependencies between
it and surrounding code (if somebody looks at the condition flags, it is
dependent on the vast majority of instructions).
But the builtin itself doesn't have any side-effects, so if we ignore the
result of the builtin, there is no point to emit anything.

There is a LRA bug that miscompiles the testcase which this patch makes
latent, which is certainly worth fixing too, but IMHO this change
(and maybe ix86_gimple_fold_builtin too which would fold it even earlier
when it looses lhs) is worth it as well.

2022-03-19  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/104971
* config/i386/i386-expand.cc
(ix86_expand_builtin) <case IX86_BUILTIN_READ_FLAGS>: If ignore,
don't push/pop anything and just return const0_rtx.

* gcc.target/i386/pr104971.c: New test.
gcc/config/i386/i386-expand.cc
gcc/testsuite/gcc.target/i386/pr104971.c [new file with mode: 0644]