]> git.ipfire.org Git - thirdparty/qemu.git/commit
slirp: Remove our_addr code
authorEd Swierk <eswierk@aristanetworks.com>
Fri, 21 Aug 2009 02:00:25 +0000 (19:00 -0700)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 28 Aug 2009 01:46:58 +0000 (20:46 -0500)
commitce0bd027df9c62766a5417521d0f08f27359d43f
treed6bdfb3a034bcfef2b98d3a53bb91f01731b2ea8
parent382f074371f7dc32a34c944c845b1698e83d8c36
slirp: Remove our_addr code

Three problems with our_addr:

- It's determined only once when qemu starts, but the address can change
(just like the DNS configuration can).

- It's supposed to be the IP address of a host network interface, but
there's no guarantee that gethostbyname(gethostname()) actually does
that: the host might be a laptop that has only a loopback interface up,
or the hostname might be localhost.localdomain, etc.

- It's useless at best: get_dns_addr() calls it, there's no reason to
send DNS requests to a different IP address if you're running a DNS
server on the host and resolv.conf points to 127.0.0.1.

These problems are easily solved by removing the code.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
slirp/main.h
slirp/slirp.c