]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfsprogs: remove write-only assignments
authorEric Sandeen <sandeen@redhat.com>
Mon, 14 Apr 2014 06:13:50 +0000 (16:13 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 14 Apr 2014 06:13:50 +0000 (16:13 +1000)
commitd0bbcbcb43fd9fadca3986c74ab129f5ee24a704
treef279c098d640427f7ae1e2b5bda2e0b034c3474f
parentd15f7cfb767b77a9c02977af8c6b03d1bfc883d0
xfsprogs: remove write-only assignments

There are many instances where variable assignments are made,
but never read (or are re-assigned before they are read).
The Clang static analyzer finds these.

Here's a chunk of what I think are trivial removals of such
assignments; other detections point to more serious problems
(or are shared w/ kernel code so should probably be fixed there
first).

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
17 files changed:
copy/xfs_copy.c
db/bmap.c
db/check.c
db/convert.c
growfs/xfs_growfs.c
include/bitops.h
libxfs/rdwr.c
logprint/log_misc.c
logprint/log_print_all.c
mkfs/xfs_mkfs.c
quota/path.c
repair/attr_repair.c
repair/dir2.c
repair/phase5.c
repair/phase6.c
repair/prefetch.c
repair/sb.c