]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/python: don't allow the user to delete window title attributes
authorAndrew Burgess <andrew.burgess@embecosm.com>
Mon, 8 Feb 2021 11:44:51 +0000 (11:44 +0000)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Mon, 8 Feb 2021 11:55:05 +0000 (11:55 +0000)
commite0c23e11da18b615c382888da8e978f16428e81b
tree92997a5c1c428d3efa2d645d75a0823903388d09
parent1cf2399651ef3fe1350ad8276cf00d16ddeb9960
gdb/python: don't allow the user to delete window title attributes

There's a bug in the python tui API.  If the user tries to delete the
window title attribute then this will trigger undefined behaviour in
GDB due to a missing nullptr check.

gdb/ChangeLog:

* python/py-tui.c (gdbpy_tui_set_title): Check that the new value
for the title is not nullptr.

gdb/testsuite/ChangeLog:

* gdb.python/tui-window.exp: Add new tests.
* gdb.python/tui-window.py (TestWindow) <__init__>: Store
TestWindow object into global the_window.
<remote_title>: New method.
(delete_window_title): New function.
gdb/ChangeLog
gdb/python/py-tui.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.python/tui-window.exp
gdb/testsuite/gdb.python/tui-window.py