]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
target_is_non_stop_p and sync targets
authorPedro Alves <pedro@palves.net>
Mon, 22 Feb 2021 00:18:10 +0000 (00:18 +0000)
committerPedro Alves <pedro@palves.net>
Fri, 26 Mar 2021 15:57:25 +0000 (15:57 +0000)
commite5b9b39f8872fa01efb9c7f8ce7283fb9cd5122d
tree608471a450639b33a4c3eac3fe91f137681aab3b
parentbab287cdcfb47ac472da9e8d3c8db8b15880c12c
target_is_non_stop_p and sync targets

gdb.base/maint-target-async-off.exp fails if you test against
gdbserver with "maint set target-non-stop on" forced.

  (gdb) run
  Starting program: build/gdb/testsuite/outputs/gdb.base/maint-target-async-off/maint-target-async-off

  Breakpoint 1, main () at src/gdb/testsuite/gdb.base/maint-target-async-off.c:21
  21        return 0;
  (gdb) FAIL: gdb.base/maint-target-async-off.exp: continue until exit (timeout)

Above, GDB just stopped listening to stdin.

Basically, GDB assumes that a target working in non-stop mode
operation also supports async mode; it's a requirement.  GDB
misbehaves badly otherwise, and even hits failed assertions.

Fix this by making target_is_non_stop_p return false if async is off.

gdb/ChangeLog:

* target.c (target_always_non_stop_p): Also check whether the
target can async.

Change-Id: I7e52e1061396a5b9b02ada462f68a14b76d68974
gdb/ChangeLog
gdb/target.c