]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
authorSimon Marchi <simon.marchi@ericsson.com>
Thu, 21 Sep 2017 12:09:33 +0000 (14:09 +0200)
committerSimon Marchi <simon.marchi@ericsson.com>
Thu, 21 Sep 2017 12:09:33 +0000 (14:09 +0200)
commitebe48ba0856dcccaa7a60d873c61e6f1f96f5887
tree7805e4f492d48fb8897323eb698ef5681a436d37
parent0a0bf5dc149ad79b325cdffb6b4e57be6c5ecbc2
microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug

I am getting this warning with clang:

/home/emaisin/src/binutils-gdb/gdb/microblaze-tdep.c:94:28: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
       vprintf_unfiltered (fmt, args);
                           ^~~

Adding ATTRIBUTE_PRINTF to microblaze_debug gets rid of it.  Strangely,
gcc doesn't warn about non-literal format strings when calling vprintf
(or a vprintf-style function, like vprintf_unfiltered).  I filed this
gcc bug:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206

gdb/ChangeLog:

* microblaze-tdep.c (microblaze_debug): Add ATTRIBUTE_PRINTF.
gdb/ChangeLog
gdb/microblaze-tdep.c