]> git.ipfire.org Git - thirdparty/qemu.git/commit
util/hbitmap: strict hbitmap_reset
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Tue, 6 Aug 2019 15:26:11 +0000 (18:26 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 4 Nov 2019 14:31:40 +0000 (08:31 -0600)
commitfcd7cba6acb7344aca70f5f8ec16626e817b35a5
tree2db63fedc204b11bd4000ba2b4ac468614221c38
parentaea18ef938c115f02e269ab6c8bc83dc5126db19
util/hbitmap: strict hbitmap_reset

hbitmap_reset has an unobvious property: it rounds requested region up.
It may provoke bugs, like in recently fixed write-blocking mode of
mirror: user calls reset on unaligned region, not keeping in mind that
there are possible unrelated dirty bytes, covered by rounded-up region
and information of this unrelated "dirtiness" will be lost.

Make hbitmap_reset strict: assert that arguments are aligned, allowing
only one exception when @start + @count == hb->orig_size. It's needed
to comfort users of hbitmap_next_dirty_area, which cares about
hb->orig_size.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20190806152611.280389-1-vsementsov@virtuozzo.com>
[Maintainer edit: Max's suggestions from on-list. --js]
[Maintainer edit: Eric's suggestion for aligned macro. --js]
Signed-off-by: John Snow <jsnow@redhat.com>
(cherry picked from commit 48557b138383aaf69c2617ca9a88bfb394fc50ec)
*prereq for fed33bd175f663cc8c13f8a490a4f35a19756cfe
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
include/qemu/hbitmap.h
tests/test-hbitmap.c
util/hbitmap.c