]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
i386: Remove CET support bits
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 9 Jan 2024 20:23:27 +0000 (12:23 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 19 Aug 2025 22:39:23 +0000 (15:39 -0700)
1. Remove _dl_runtime_resolve_shstk and _dl_runtime_profile_shstk.
2. Move CET offsets from x86 cpu-features-offsets.sym to x86-64
features-offsets.sym.
3. Rename x86 cet-control.h to x86-64 feature-control.h since it is only
for x86-64 and also used for PLT rewrite.
4. Add x86-64 ldsodefs.h to include feature-control.h.
5. Change TUNABLE_CALLBACK (set_plt_rewrite) to x86-64 only.
6. Move x86 dl-procruntime.c to x86-64.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
(cherry picked from commit 874214db624a8e6c5d2dbe47419fab126f330d68)

sysdeps/i386/dl-machine.h
sysdeps/i386/dl-trampoline.S
sysdeps/unix/sysv/linux/x86_64/dl-cet.h
sysdeps/x86/cpu-features-offsets.sym
sysdeps/x86/ldsodefs.h
sysdeps/x86_64/Makefile
sysdeps/x86_64/dl-procruntime.c [moved from sysdeps/x86/dl-procruntime.c with 94% similarity]
sysdeps/x86_64/dl-trampoline.S
sysdeps/x86_64/feature-control.h [moved from sysdeps/x86/cet-control.h with 90% similarity]
sysdeps/x86_64/features-offsets.sym [new file with mode: 0644]
sysdeps/x86_64/ldsodefs.h [new file with mode: 0644]

index 18749f2ec2509d99f4e68d6c19ad21489b4970c6..b21322adc83f10fb04ca714bc145da27b001fe05 100644 (file)
@@ -65,9 +65,6 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
   extern void _dl_runtime_profile (Elf32_Word) attribute_hidden;
   extern void _dl_runtime_resolve_shstk (Elf32_Word) attribute_hidden;
   extern void _dl_runtime_profile_shstk (Elf32_Word) attribute_hidden;
-  /* Check if SHSTK is enabled by kernel.  */
-  bool shstk_enabled
-    = (GL(dl_x86_feature_1) & GNU_PROPERTY_X86_FEATURE_1_SHSTK) != 0;
 
   if (l->l_info[DT_JMPREL] && lazy)
     {
@@ -94,9 +91,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
         end in this function.  */
       if (__glibc_unlikely (profile))
        {
-         got[2] = (shstk_enabled
-                   ? (Elf32_Addr) &_dl_runtime_profile_shstk
-                   : (Elf32_Addr) &_dl_runtime_profile);
+         got[2] = (Elf32_Addr) &_dl_runtime_profile;
 
          if (GLRO(dl_profile) != NULL
              && _dl_name_match_p (GLRO(dl_profile), l))
@@ -107,9 +102,7 @@ elf_machine_runtime_setup (struct link_map *l, struct r_scope_elem *scope[],
       else
        /* This function will get called to fix up the GOT entry indicated by
           the offset on the stack, and then jump to the resolved address.  */
-       got[2] = (shstk_enabled
-                 ? (Elf32_Addr) &_dl_runtime_resolve_shstk
-                 : (Elf32_Addr) &_dl_runtime_resolve);
+       got[2] = (Elf32_Addr) &_dl_runtime_resolve;
     }
 
   return lazy;
index 1c569290a5b73f0e6c5fd00dbbe07f5d996e7d89..5fe8600783ea9a1bcfa1116f409ef3ad9ff2312f 100644 (file)
@@ -44,76 +44,7 @@ _dl_runtime_resolve:
        cfi_endproc
        .size _dl_runtime_resolve, .-_dl_runtime_resolve
 
-# The SHSTK compatible version.
-       .text
-       .globl _dl_runtime_resolve_shstk
-       .type _dl_runtime_resolve_shstk, @function
-       cfi_startproc
-       .align 16
-_dl_runtime_resolve_shstk:
-       cfi_adjust_cfa_offset (8)
-       pushl %eax              # Preserve registers otherwise clobbered.
-       cfi_adjust_cfa_offset (4)
-       pushl %edx
-       cfi_adjust_cfa_offset (4)
-       movl 12(%esp), %edx     # Copy args pushed by PLT in register.  Note
-       movl 8(%esp), %eax      # that `fixup' takes its parameters in regs.
-       call _dl_fixup          # Call resolver.
-       movl (%esp), %edx       # Get register content back.
-       movl %eax, %ecx         # Store the function address.
-       movl 4(%esp), %eax      # Get register content back.
-       addl $16, %esp          # Adjust stack: PLT1 + PLT2 + %eax + %edx
-       cfi_adjust_cfa_offset (-16)
-       jmp *%ecx               # Jump to function address.
-       cfi_endproc
-       .size _dl_runtime_resolve_shstk, .-_dl_runtime_resolve_shstk
-
 #ifndef PROF
-# The SHSTK compatible version.
-       .globl _dl_runtime_profile_shstk
-       .type _dl_runtime_profile_shstk, @function
-       cfi_startproc
-       .align 16
-_dl_runtime_profile_shstk:
-       cfi_adjust_cfa_offset (8)
-       pushl %esp
-       cfi_adjust_cfa_offset (4)
-       addl $8, (%esp)         # Account for the pushed PLT data
-       pushl %ebp
-       cfi_adjust_cfa_offset (4)
-       pushl %eax              # Preserve registers otherwise clobbered.
-       cfi_adjust_cfa_offset (4)
-       pushl %ecx
-       cfi_adjust_cfa_offset (4)
-       pushl %edx
-       cfi_adjust_cfa_offset (4)
-       movl %esp, %ecx
-       subl $8, %esp
-       cfi_adjust_cfa_offset (8)
-       movl $-1, 4(%esp)
-       leal 4(%esp), %edx
-       movl %edx, (%esp)
-       pushl %ecx              # Address of the register structure
-       cfi_adjust_cfa_offset (4)
-       movl 40(%esp), %ecx     # Load return address
-       movl 36(%esp), %edx     # Copy args pushed by PLT in register.  Note
-       movl 32(%esp), %eax     # that `fixup' takes its parameters in regs.
-       call _dl_profile_fixup  # Call resolver.
-       cfi_adjust_cfa_offset (-8)
-       movl (%esp), %edx
-       testl %edx, %edx
-       jns 1f
-       movl 4(%esp), %edx      # Get register content back.
-       movl %eax, %ecx         # Store the function address.
-       movl 12(%esp), %eax     # Get register content back.
-       # Adjust stack: PLT1 + PLT2 + %esp + %ebp + %eax + %ecx + %edx
-       # + free.
-       addl $32, %esp
-       cfi_adjust_cfa_offset (-32)
-       jmp *%ecx               # Jump to function address.
-       cfi_endproc
-       .size _dl_runtime_profile_shstk, .-_dl_runtime_profile_shstk
-
        .globl _dl_runtime_profile
        .type _dl_runtime_profile, @function
        cfi_startproc
index 64022a631a46f9b5ceb880a372d704064f9237b4..ed4a81ea3d983f2ba51db7bb0f661388a13b8799 100644 (file)
@@ -17,7 +17,7 @@
 
 #include <sys/prctl.h>
 #include <asm/prctl.h>
-#include <cpu-features-offsets.h>
+#include <features-offsets.h>
 
 static __always_inline int
 dl_cet_disable_cet (unsigned int cet_feature)
index 5429f6063218fcc1026f33e30642cf0d5c66fea2..6a8fd298137b7f23fb77c7d51de69116959f5cf5 100644 (file)
@@ -2,6 +2,4 @@
 
 #include <ldsodefs.h>
 
-RTLD_GLOBAL_RO_DL_X86_CPU_FEATURES_OFFSET offsetof (struct rtld_global_ro, _dl_x86_cpu_features)
 XSAVE_STATE_SIZE_OFFSET        offsetof (struct cpu_features, xsave_state_size)
-RTLD_GLOBAL_DL_X86_FEATURE_1_OFFSET offsetof (struct rtld_global, _dl_x86_feature_1)
index 7af12e515f11ed1e92c116396fa0aea7641b1232..fda0376738d1bc26e17d9d532514cc455c972641 100644 (file)
@@ -61,7 +61,6 @@ struct La_x32_retval;
                                     struct La_x86_64_retval *,         \
                                     const char *)
 
-#include <cet-control.h>
 #include_next <ldsodefs.h>
 
 #endif
index 36be2f6d56ff8ab67e3ed5d271e809bc3d303eac..a3b0440aa731786e0280d8c4cd5c1d17091ca981 100644 (file)
@@ -2,7 +2,7 @@
 long-double-fcts = yes
 
 ifeq ($(subdir),csu)
-gen-as-const-headers += link-defines.sym
+gen-as-const-headers += features-offsets.sym link-defines.sym
 endif
 
 ifeq ($(subdir),gmon)
similarity index 94%
rename from sysdeps/x86/dl-procruntime.c
rename to sysdeps/x86_64/dl-procruntime.c
index 2fb682ded3bf9ed3e346de3bee92749c37c0cdf2..8457441315f1c1e5171abd2ebdd18cd442ebf480 100644 (file)
@@ -1,5 +1,5 @@
-/* Data for processor runtime information.  x86 version.
-   Copyright (C) 2018-2023 Free Software Foundation, Inc.
+/* Data for processor runtime information.  x86-64 version.
+   Copyright (C) 2018-2024 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
index a6b9a1826b86f0f97818783419f171c36f4b5556..3c185006908f0ce64795f862def7c04a6f00af83 100644 (file)
@@ -19,6 +19,7 @@
 #include <config.h>
 #include <sysdep.h>
 #include <cpu-features-offsets.h>
+#include <features-offsets.h>
 #include <link-defines.h>
 #include <isa-level.h>
 
similarity index 90%
rename from sysdeps/x86/cet-control.h
rename to sysdeps/x86_64/feature-control.h
index 3bd00019e85b8cc91bb84ba3e1be9ee8291fa6d9..d334804b1923b79808aefeb108be8c9446246bec 100644 (file)
@@ -1,4 +1,4 @@
-/* x86 CET tuning.
+/* x86-64 feature tuning.
    This file is part of the GNU C Library.
    Copyright (C) 2018-2023 Free Software Foundation, Inc.
 
@@ -16,8 +16,8 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#ifndef _CET_CONTROL_H
-#define _CET_CONTROL_H
+#ifndef _X86_64_FEATURE_CONTROL_H
+#define _X86_64_FEATURE_CONTROL_H
 
 /* For each CET feature, IBT and SHSTK, valid control values.  */
 enum dl_x86_cet_control
@@ -38,4 +38,4 @@ struct dl_x86_feature_control
   enum dl_x86_cet_control shstk : 2;
 };
 
-#endif /* cet-control.h */
+#endif /* feature-control.h */
diff --git a/sysdeps/x86_64/features-offsets.sym b/sysdeps/x86_64/features-offsets.sym
new file mode 100644 (file)
index 0000000..9e4be33
--- /dev/null
@@ -0,0 +1,6 @@
+#define SHARED 1
+
+#include <ldsodefs.h>
+
+RTLD_GLOBAL_RO_DL_X86_CPU_FEATURES_OFFSET offsetof (struct rtld_global_ro, _dl_x86_cpu_features)
+RTLD_GLOBAL_DL_X86_FEATURE_1_OFFSET offsetof (struct rtld_global, _dl_x86_feature_1)
diff --git a/sysdeps/x86_64/ldsodefs.h b/sysdeps/x86_64/ldsodefs.h
new file mode 100644 (file)
index 0000000..0f468dd
--- /dev/null
@@ -0,0 +1,26 @@
+/* Run-time dynamic linker data structures for loaded ELF shared objects.
+   x86-64 version.
+   Copyright (C) 2024 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef        _X86_64_LDSODEFS_H
+#define        _X86_64_LDSODEFS_H      1
+
+#include <feature-control.h>
+#include_next <ldsodefs.h>
+
+#endif