]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
lib/crypto: tests: Fix KMSAN warning in test_sha256_finup_2x()
authorEric Biggers <ebiggers@kernel.org>
Fri, 21 Nov 2025 03:34:31 +0000 (19:34 -0800)
committerEric Biggers <ebiggers@kernel.org>
Fri, 21 Nov 2025 18:22:24 +0000 (10:22 -0800)
Fully initialize *ctx, including the buf field which sha256_init()
doesn't initialize, to avoid a KMSAN warning when comparing *ctx to
orig_ctx.  This KMSAN warning slipped in while KMSAN was not working
reliably due to a stackdepot bug, which has now been fixed.

Fixes: 6733968be7cb ("lib/crypto: tests: Add tests and benchmark for sha256_finup_2x()")
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20251121033431.34406-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
lib/crypto/tests/sha256_kunit.c

index dcedfca06df658119375a5258e4724157bd0e9cb..5dccdee79693a88eb0ad67a34155af1a71aa9daa 100644 (file)
@@ -68,6 +68,7 @@ static void test_sha256_finup_2x(struct kunit *test)
        rand_bytes(data1_buf, max_data_len);
        rand_bytes(data2_buf, max_data_len);
        rand_bytes(salt, sizeof(salt));
+       memset(ctx, 0, sizeof(*ctx));
 
        for (size_t i = 0; i < 500; i++) {
                size_t salt_len = rand_length(sizeof(salt));