]> git.ipfire.org Git - thirdparty/git.git/commitdiff
Merge branch 'cp/sideband-array-index-comment-fix' into maint-2.43
authorJunio C Hamano <gitster@pobox.com>
Fri, 9 Feb 2024 00:22:12 +0000 (16:22 -0800)
committerJunio C Hamano <gitster@pobox.com>
Fri, 9 Feb 2024 00:22:12 +0000 (16:22 -0800)
In-code comment fix.

* cp/sideband-array-index-comment-fix:
  sideband.c: remove redundant 'NEEDSWORK' tag

1  2 
sideband.c

diff --combined sideband.c
index 6cbfd391c47fb531740eb4b963a11b77f8abe29d,cdbe0789f0b44376b8ac85a85e2f32b6d0703a13..266a67342be7245ae3c1dfae5a1a5ad6647f95df
@@@ -1,12 -1,9 +1,12 @@@
 -#include "cache.h"
 +#include "git-compat-util.h"
  #include "color.h"
  #include "config.h"
 +#include "editor.h"
 +#include "gettext.h"
  #include "sideband.h"
  #include "help.h"
  #include "pkt-line.h"
 +#include "write-or-die.h"
  
  struct keyword_entry {
        /*
@@@ -69,7 -66,10 +69,10 @@@ void list_config_color_sideband_slots(s
   * of the line. This should be called for a single line only, which is
   * passed as the first N characters of the SRC array.
   *
-  * NEEDSWORK: use "size_t n" instead for clarity.
+  * It is fine to use "int n" here instead of "size_t n" as all calls to this
+  * function pass an 'int' parameter. Additionally, the buffer involved in
+  * storing these 'int' values takes input from a packet via the pkt-line
+  * interface, which is capable of transferring only 64kB at a time.
   */
  static void maybe_colorize_sideband(struct strbuf *dest, const char *src, int n)
  {