]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree
authorHarshad Shirwadkar <harshadshirwadkar@gmail.com>
Tue, 23 Feb 2021 17:41:53 +0000 (09:41 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 23 Feb 2021 17:58:03 +0000 (12:58 -0500)
Don't ignore return values of library function calls in
e2fsck_rewrite_extent_tree.

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
e2fsck/extents.c

index 180fb3acf56baff4be3fadb3b0a1ec24b315bd22..4e6e2611352f8cdddd50df2bedd9949411c47db4 100644 (file)
@@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list)
        errcode_t err;
 
        memset(&inode, 0, sizeof(inode));
-       ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
-                               sizeof(inode));
+       err = ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
+                                    sizeof(inode));
+       if (err)
+               return err;
 
        /* Skip deleted inodes and inline data files */
        if (inode.i_flags & EXT4_INLINE_DATA_FL)
@@ -305,11 +307,11 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list)
                                  &blk_count);
        if (err)
                return err;
-       ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count);
-       ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
-               sizeof(inode));
-
-       return 0;
+       err = ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count);
+       if (err)
+               return err;
+       return ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode),
+                                      sizeof(inode));
 }
 
 errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list *extents)