]> git.ipfire.org Git - people/ms/linux.git/commitdiff
x86/sgx: Mark PCMD page as dirty when modifying contents
authorReinette Chatre <reinette.chatre@intel.com>
Thu, 12 May 2022 21:50:58 +0000 (14:50 -0700)
committerDave Hansen <dave.hansen@linux.intel.com>
Mon, 16 May 2022 22:17:14 +0000 (15:17 -0700)
Recent commit 08999b2489b4 ("x86/sgx: Free backing memory
after faulting the enclave page") expanded __sgx_encl_eldu()
to clear an enclave page's PCMD (Paging Crypto MetaData)
from the PCMD page in the backing store after the enclave
page is restored to the enclave.

Since the PCMD page in the backing store is modified the page
should be marked as dirty to ensure the modified data is retained.

Cc: stable@vger.kernel.org
Fixes: 08999b2489b4 ("x86/sgx: Free backing memory after faulting the enclave page")
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Tested-by: Haitao Huang <haitao.huang@intel.com>
Link: https://lkml.kernel.org/r/00cd2ac480db01058d112e347b32599c1a806bc4.1652389823.git.reinette.chatre@intel.com
arch/x86/kernel/cpu/sgx/encl.c

index 398695a206050aa62742aa376fddd0f7b6167709..5104a428b72cd95616e6cf6e338d319096a51691 100644 (file)
@@ -84,6 +84,7 @@ static int __sgx_encl_eldu(struct sgx_encl_page *encl_page,
        }
 
        memset(pcmd_page + b.pcmd_offset, 0, sizeof(struct sgx_pcmd));
+       set_page_dirty(b.pcmd);
 
        /*
         * The area for the PCMD in the page was zeroed above.  Check if the