BUG/MINOR: acme: fix initialization issue in acme_gen_tmp_x509()

src/acme.c: In function ‘acme_gen_tmp_x509’:
src/acme.c:2685:15: error: ‘digest’ may be used uninitialized [-Werror=maybe-uninitialized]
 2685 |         if (!(X509_sign(newcrt, pkey, digest)))
      |              ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/acme.c:2628:23: note: ‘digest’ was declared here
 2628 |         const EVP_MD *digest;
      |                       ^~~~~~

diff --git a/src/acme.c b/src/acme.c
index 96a0cca42b7a5b8d20d6181cc429d0882f1e2c7f..33fec5030b87f8ba26b175a10632fb468537fddc 100644 (file)
--- a/src/acme.c
+++ b/src/acme.c
@@ -2625,7 +2625,7 @@ X509 *acme_gen_tmp_x509()
 {
        X509         *newcrt  = NULL;
        X509_NAME    *name;
-       const EVP_MD *digest;
+       const EVP_MD *digest = NULL;
        CONF         *ctmp    = NULL;
        int           key_type;
        EVP_PKEY *pkey = tmp_pkey;
@@ -2681,6 +2681,8 @@ X509 *acme_gen_tmp_x509()
                digest = EVP_sha256();
        else if (key_type == EVP_PKEY_EC)
                digest = EVP_sha256();
+       else
+               goto mkcert_error;
 
        if (!(X509_sign(newcrt, pkey, digest)))
                goto mkcert_error;