t3905: replace test -s with test_file_not_empty

In order to modernize the test script, replace `test -s` with
test_file_not_empty(), which provides better diagnostic output in the
case of failure.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t3905-stash-include-untracked.sh b/t/t3905-stash-include-untracked.sh
index f008e5d9457bd146a27d183848b3fc57e90823d6..c87ac24042f2826317ffcd51868fb353c5e3fb20 100755 (executable)
--- a/t/t3905-stash-include-untracked.sh
+++ b/t/t3905-stash-include-untracked.sh
@@ -169,9 +169,9 @@ test_expect_success 'stash save --include-untracked respects .gitignore' '
        mkdir ignored.d &&
        echo ignored >ignored.d/untracked &&
        git stash -u &&
-       test -s ignored &&
-       test -s ignored.d/untracked &&
-       test -s .gitignore
+       test_file_not_empty ignored &&
+       test_file_not_empty ignored.d/untracked &&
+       test_file_not_empty .gitignore
 '
 
 test_expect_success 'stash save -u can stash with only untracked files different' '
@@ -189,9 +189,9 @@ test_expect_success 'stash save --all does not respect .gitignore' '
 
 test_expect_success 'stash save --all is stash poppable' '
        git stash pop &&
-       test -s ignored &&
-       test -s ignored.d/untracked &&
-       test -s .gitignore
+       test_file_not_empty ignored &&
+       test_file_not_empty ignored.d/untracked &&
+       test_file_not_empty .gitignore
 '
 
 test_expect_success 'stash push --include-untracked with pathspec' '