]> git.ipfire.org Git - oddments/collecty.git/commitdiff
graphs: disk: Add a comment about discards
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 31 Oct 2025 17:42:53 +0000 (17:42 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 31 Oct 2025 17:42:53 +0000 (17:42 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/daemon/graphs/disk.c

index a9e94fe26b6d538addd66ca832c981daef6bd0f3..7a15fbedd4efa3b68032476c7fdf575e9d247d16 100644 (file)
@@ -43,7 +43,9 @@ static int disk_io_render(td_ctx* ctx, td_graph* graph,
        // Draw the temperature
        DRAW_IO_BYTES_FROM_SECTORS(args, object, "read_sectors", "write_sectors");
 
-       // XXX TODO Add discarded bytes
+       // I tried to add the discarded bytes here, but it has been a surprisingly high
+       // amount of discards. There have been massive spikes (I assume from fstrim) and
+       // generally enough data to constantly draw over the graph. So it wasn't usable.
 
        return 0;
 }