]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
spi: mxc_spi: Fix spi clock glitch durant reset
authorFabio Estevam <fabio.estevam@freescale.com>
Thu, 15 Nov 2012 11:23:24 +0000 (11:23 +0000)
committerStefano Babic <sbabic@denx.de>
Mon, 19 Nov 2012 07:49:00 +0000 (08:49 +0100)
Measuring the spi clock line on a scope shows a 'glitch' during the reset of the
spi.

Fix this by toggling only the MXC_CSPICTRL_EN bit, so that the clock line becomes
always stable.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
drivers/spi/mxc_spi.c

index b6bad989527b75b6e94d1f1184e929a66203e9e1..859c43fee2790de7c80335bb58a71b20934c49f9 100644 (file)
@@ -140,8 +140,8 @@ static s32 spi_cfg_mxc(struct mxc_spi_slave *mxcs, unsigned int cs,
        reg_ctrl = reg_read(&regs->ctrl);
 
        /* Reset spi */
-       reg_write(&regs->ctrl, 0);
-       reg_write(&regs->ctrl, (reg_ctrl | 0x1));
+       reg_write(&regs->ctrl, (reg_ctrl & ~MXC_CSPICTRL_EN));
+       reg_write(&regs->ctrl, (reg_ctrl | MXC_CSPICTRL_EN));
 
        /*
         * The following computation is taken directly from Freescale's code.