]> git.ipfire.org Git - thirdparty/git.git/commitdiff
bisect: fix internal diff-tree config loading
authorJeff King <peff@peff.net>
Fri, 22 Feb 2019 06:21:33 +0000 (01:21 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 28 Feb 2019 22:31:37 +0000 (07:31 +0900)
When we run our internal diff-tree to show the bisected commit, we call
init_revisions(), then load config, then setup_revisions(). But that
order is wrong: we copy the configured defaults into the rev_info struct
during the init_revisions step, so our config load wasn't actually doing
anything.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
bisect.c

index 8c8185983558388f13590160e820b6168bd40ea5..b04d7b2f631325d7847d1092b7d024a1c8252b40 100644 (file)
--- a/bisect.c
+++ b/bisect.c
@@ -901,8 +901,8 @@ static void show_diff_tree(struct repository *r,
        };
        struct rev_info opt;
 
-       repo_init_revisions(r, &opt, prefix);
        git_config(git_diff_basic_config, NULL); /* no "diff" UI options */
+       repo_init_revisions(r, &opt, prefix);
 
        setup_revisions(ARRAY_SIZE(argv) - 1, argv, &opt, NULL);
        log_tree_commit(&opt, commit);