manage: Correctly handle port 65535 in man_kill

Commit c66d433111c958c42cc98f4ba12d3cfc1bd5b3b4 introduced
an off-by-one when changing a literal to a constant.

Github: fixes OpenVPN/openvpn#887
Change-Id: I19373408a82332d7b2e5c634e5509c8be3727b5a
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1341
Message-Id: <20251103115552.6201-1-gert@greenie.muc.de>
Signed-off-by: Gert Doering <gert@greenie.muc.de>

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index e46b5f227ac15e94e6217357ac53a1b8c99ebe03..6efa1001a80fdcdbda5322b2bd06468605c7a3c0 100644 (file)
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -612,7 +612,7 @@ man_kill(struct management *man, const char *victim)
                                       : (streq(p1, "udp")) ? PROTO_UDP
                                                            : PROTO_NONE;
 
-                if ((port > 0 && port < UINT16_MAX) && (proto != PROTO_NONE))
+                if ((port > 0 && port <= UINT16_MAX) && (proto != PROTO_NONE))
                 {
                     n_killed = (*man->persist.callback.kill_by_addr)(man->persist.callback.arg,
                                                                      addr, (uint16_t)port, proto);