]> git.ipfire.org Git - thirdparty/git.git/commitdiff
format_trailer_info(): drop redundant unfold_value()
authorLinus Arver <linusa@google.com>
Fri, 15 Mar 2024 06:55:02 +0000 (06:55 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 15 Mar 2024 17:10:24 +0000 (10:10 -0700)
This is another preparatory refactor to unify the trailer formatters.

In the last patch we made format_trailer_info() use trailer_item objects
instead of the "trailers" string array. This means that the call to
unfold_value() here is redundant because the trailer_item objects are
already unfolded in parse_trailers() which is a dependency of our
caller, format_trailers_from_commit().

Remove the redundant call.

Signed-off-by: Linus Arver <linusa@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
trailer.c

index a74f05db55c8d0f410489e39b61224922f819ec2..2c0dd8ac829d547e9894b789e369cd5dfcde7a08 100644 (file)
--- a/trailer.c
+++ b/trailer.c
@@ -1101,9 +1101,6 @@ static void format_trailer_info(const struct process_trailer_options *opts,
                        strbuf_addstr(&val, item->value);
 
                        if (!opts->filter || opts->filter(&tok, opts->filter_data)) {
-                               if (opts->unfold)
-                                       unfold_value(&val);
-
                                if (opts->separator && out->len != origlen)
                                        strbuf_addbuf(out, opts->separator);
                                if (!opts->value_only)