- Use "major", "minor", "makedev" macros instead of
"MAJOR", "MINOR", "MKDEV" so that large device numbers work
on 2.6 (providing you have glibc 2.3.3 or later).
+ - Add some missing closes of open file descriptors.
Changes Prior to 1.8.0 release
- Makefile cleanup from Luca Berra <bluca@comedia.it>
}
if (ioctl(mdfd, GET_ARRAY_INFO, &array)>=0)
/* already assembled, skip */
- continue;
- rv |= Assemble(array_list->devname, mdfd,
- array_list, configfile,
- NULL,
- readonly, runstop, NULL, verbose, force);
+ ;
+ else
+ rv |= Assemble(array_list->devname, mdfd,
+ array_list, configfile,
+ NULL,
+ readonly, runstop, NULL, verbose, force);
+ close(mdfd);
}
}
break;
rv |= Detail(name, !verbose, test);
else if (devmode=='S') {
mdfd = open_mddev(name, 0);
- if (mdfd >= 0)
+ if (mdfd >= 0) {
rv |= Manage_runstop(name, mdfd, -1);
+ close(mdfd);
+ }
}
put_md_name(name);
}
rv |= Query(dv->devname); continue;
}
mdfd = open_mddev(dv->devname, 0);
- if (mdfd>=0)
+ if (mdfd>=0) {
switch(dv->disposition) {
case 'R':
rv |= Manage_runstop(dv->devname, mdfd, 1); break;
case 'w':
rv |= Manage_ro(dv->devname, mdfd, -1); break;
}
+ close(mdfd);
+ }
}
}
break;