grep: demonstrate bug with textconv attributes and submodules

In some circumstances, "git grep --textconv --recurse-submodules"
ignores the textconv attributes from the submodules and erroneously
applies the attributes defined in the superproject on the submodules'
files. The textconv cache is also saved on the superproject, even for
submodule objects.

A fix for these problems will probably require at least three changes:

- Some textconv and attributes functions (as well as their callees) will
  have to be adjusted to work with arbitrary repositories. Note that
  "fill_textconv()", for example, already receives a "struct repository"
  but it writes the textconv cache using "write_loose_object()", which
  implicitly works on "the_repository".

- grep.c functions will have to call textconv/userdiff routines passing
  the "repo" field from "struct grep_source" instead of the one from
  "struct grep_opt". The latter always points to "the_repository" on
  "git grep" executions (see its initialization in builtin/grep.c), but
  the former points to the correct repository that each source (an
  object, file, or buffer) comes from.

- "userdiff_find_by_path()" might need to use a different attributes
  stack for each repository it works on or reset its internal static
  stack when the repository is changed throughout the calls.

For now, let's add some tests to demonstrate these problems, and also
update a NEEDSWORK comment in grep.h that mentions this bug to reference
the added tests.

Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/grep.h b/grep.h
index 128007db655e4e2def53e17cfd2a0d0ee3fefa18..3b63bd0253854763665a89c60512861889a70cce 100644 (file)
--- a/grep.h
+++ b/grep.h
@@ -128,9 +128,9 @@ struct grep_opt {
         * instead.
         *
         * This is potentially the cause of at least one bug - "git grep"
-        * ignoring the textconv attributes from submodules. See [1] for more
-        * information.
-        * [1] https://lore.kernel.org/git/CAHd-oW5iEQarYVxEXoTG-ua2zdoybTrSjCBKtO0YT292fm0NQQ@mail.gmail.com/
+        * using the textconv attributes from the superproject on the
+        * submodules. See the failing "git grep --textconv" tests in
+        * t7814-grep-recurse-submodules.sh for more information.
         */
        struct repository *repo;
 

diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh
index 3172f5b936489e53e36243465b586eeb26c24ed0..058e5d0c966dfd8fe816de8fdc6bcff7f93a70ac 100755 (executable)
--- a/t/t7814-grep-recurse-submodules.sh
+++ b/t/t7814-grep-recurse-submodules.sh
@@ -441,4 +441,107 @@ test_expect_success 'grep --recurse-submodules with --cached ignores worktree mo
        test_must_fail git grep --recurse-submodules --cached "A modified line in submodule" >actual 2>&1 &&
        test_must_be_empty actual
 '
+
+test_expect_failure 'grep --textconv: superproject .gitattributes does not affect submodules' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+       echo "a diff=d2x" >.gitattributes &&
+
+       cat >expect <<-\EOF &&
+       a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+test_expect_failure 'grep --textconv: superproject .gitattributes (from index) does not affect submodules' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+       echo "a diff=d2x" >.gitattributes &&
+       git add .gitattributes &&
+       rm .gitattributes &&
+
+       cat >expect <<-\EOF &&
+       a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+test_expect_failure 'grep --textconv: superproject .git/info/attributes does not affect submodules' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+       super_attr="$(git rev-parse --git-path info/attributes)" &&
+       test_when_finished "rm -f \"$super_attr\"" &&
+       echo "a diff=d2x" >"$super_attr" &&
+
+       cat >expect <<-\EOF &&
+       a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+# Note: what currently prevents this test from passing is not that the
+# .gitattributes file from "./submodule" is being ignored, but that it is being
+# propagated to the nested "./submodule/sub" files.
+#
+test_expect_failure 'grep --textconv correctly reads submodule .gitattributes' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+       echo "a diff=d2x" >submodule/.gitattributes &&
+
+       cat >expect <<-\EOF &&
+       submodule/a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+test_expect_failure 'grep --textconv correctly reads submodule .gitattributes (from index)' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+       echo "a diff=d2x" >submodule/.gitattributes &&
+       git -C submodule add .gitattributes &&
+       rm submodule/.gitattributes &&
+
+       cat >expect <<-\EOF &&
+       submodule/a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+test_expect_failure 'grep --textconv correctly reads submodule .git/info/attributes' '
+       reset_and_clean &&
+       test_config_global diff.d2x.textconv "sed -e \"s/d/x/\"" &&
+
+       submodule_attr="$(git -C submodule rev-parse --path-format=absolute --git-path info/attributes)" &&
+       test_when_finished "rm -f \"$submodule_attr\"" &&
+       echo "a diff=d2x" >"$submodule_attr" &&
+
+       cat >expect <<-\EOF &&
+       submodule/a:(1|2)x(3|4)
+       EOF
+       git grep --textconv --recurse-submodules x >actual &&
+       test_cmp expect actual
+'
+
+test_expect_failure 'grep saves textconv cache in the appropriate repository' '
+       reset_and_clean &&
+       test_config_global diff.d2x_cached.textconv "sed -e \"s/d/x/\"" &&
+       test_config_global diff.d2x_cached.cachetextconv true &&
+       echo "a diff=d2x_cached" >submodule/.gitattributes &&
+
+       # We only read/write to the textconv cache when grepping from an OID,
+       # as the working tree file might have modifications.
+       git grep --textconv --cached --recurse-submodules x &&
+
+       super_textconv_cache="$(git rev-parse --git-path refs/notes/textconv/d2x_cached)" &&
+       sub_textconv_cache="$(git -C submodule rev-parse \
+                       --path-format=absolute --git-path refs/notes/textconv/d2x_cached)" &&
+       test_path_is_missing "$super_textconv_cache" &&
+       test_path_is_file "$sub_textconv_cache"
+'
+
 test_done