]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-hwdb: use return value from ordered_hashmap_iterate()
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sat, 3 Aug 2019 15:43:51 +0000 (17:43 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sat, 3 Aug 2019 15:43:51 +0000 (17:43 +0200)
Why not? Coverity CID#1402329.

src/libsystemd/sd-hwdb/sd-hwdb.c

index 79fe1a83a715d0690688b4de2d9108225cc98c7f..58124abd21d0f44496a22dd686b97934195f7fff 100644 (file)
@@ -457,8 +457,7 @@ _public_ int sd_hwdb_enumerate(sd_hwdb *hwdb, const char **key, const char **val
         if (hwdb->properties_modified)
                 return -EAGAIN;
 
-        ordered_hashmap_iterate(hwdb->properties, &hwdb->properties_iterator, (void **)&entry, &k);
-        if (!k)
+        if (!ordered_hashmap_iterate(hwdb->properties, &hwdb->properties_iterator, (void **)&entry, &k))
                 return 0;
 
         *key = k;