]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target/sparc: Fix npc comparison in sparc_tr_insn_start
authorRichard Henderson <richard.henderson@linaro.org>
Wed, 28 Jun 2023 07:11:56 +0000 (09:11 +0200)
committerMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Wed, 28 Jun 2023 09:53:02 +0000 (10:53 +0100)
During translation, npc == address, DYNAMIC_PC, or JUMP_PC.
It is only the encoding between here and sparc_restore_state_to_opc
that considers JUMP_PC to be a bit within a larger value.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230628071202.230991-3-richard.henderson@linaro.org>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
target/sparc/translate.c

index 28d4cdb8b41691a339798eda8f626317e87dcc80..eec6f9ca678d5d0f28aec6911c5a04a89f66398f 100644 (file)
@@ -5594,7 +5594,7 @@ static void sparc_tr_insn_start(DisasContextBase *dcbase, CPUState *cs)
 {
     DisasContext *dc = container_of(dcbase, DisasContext, base);
 
-    if (dc->npc & JUMP_PC) {
+    if (dc->npc == JUMP_PC) {
         assert(dc->jump_pc[1] == dc->pc + 4);
         tcg_gen_insn_start(dc->pc, dc->jump_pc[0] | JUMP_PC);
     } else {