]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: fix file descriptor leak in test-catalog
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 22 Feb 2022 12:11:51 +0000 (21:11 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 22 Feb 2022 12:50:29 +0000 (21:50 +0900)
Fixes an issue reported in #22576.

src/libsystemd/sd-journal/test-catalog.c

index 316c3b16344ad29f5f343c0e410b1dbd6a4379d0..ad0622117519a12251524f2de63edfaab508de9b 100644 (file)
@@ -196,6 +196,7 @@ static void test_catalog_file_lang(void) {
 
 int main(int argc, char *argv[]) {
         _cleanup_(unlink_tempfilep) char database[] = "/tmp/test-catalog.XXXXXX";
+        _cleanup_close_ int fd = -1;
         _cleanup_free_ char *text = NULL;
         int r;
 
@@ -218,7 +219,7 @@ int main(int argc, char *argv[]) {
         test_catalog_import_merge();
         test_catalog_import_merge_no_body();
 
-        assert_se(mkostemp_safe(database) >= 0);
+        assert_se((fd = mkostemp_safe(database)) >= 0);
 
         test_catalog_update(database);