]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix Coverity 1503329 use after free
authorPauli <pauli@openssl.org>
Fri, 1 Apr 2022 01:18:44 +0000 (12:18 +1100)
committerPauli <pauli@openssl.org>
Fri, 6 May 2022 08:21:22 +0000 (18:21 +1000)
Another false positive tagged as such

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/18014)

crypto/store/store_lib.c

index 696056e370b6e8bbdb83c12fae9ed3998394bdb5..3d91f159b69979ec120f9b85806e127f8eed995d 100644 (file)
@@ -215,6 +215,8 @@ OSSL_STORE_open_ex(const char *uri, OSSL_LIB_CTX *libctx, const char *propq,
          */
         (void)ossl_store_close_it(&tmpctx);
     }
+    /* Coverity false positive, the reference counting is confusing it */
+    /* coverity[pass_freed_arg] */
     OSSL_STORE_LOADER_free(fetched_loader);
     OPENSSL_free(propq_copy);
     OPENSSL_free(ctx);