Printing to old CUPS servers has been fixed (Issue #5211)

cups/dest-options.c:
- Fix IPP version check in cupsCopyDestInfo.

diff --git a/CHANGES.md b/CHANGES.md
index a7ba32c0372ae8f98c1d8e90d45b3b5e56779f07..66e4c283064f0d5bfef8cb7b0f1ccac82c1e6285 100644 (file)
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,4 +1,4 @@
-CHANGES - 2.3b2 - 2018-01-10
+CHANGES - 2.3b2 - 2018-01-11
 ============================
 
 
@@ -9,6 +9,7 @@ Changes in CUPS v2.3b2
 - Build fixes (Issue #5217)
 - The `cupsGetDests` and `cupsEnumDests` functions no longer filter out local
   print services like IPP USB devices (Issue #5206)
+- Printing to old CUPS servers has been fixed (Issue #5211)
 - The `ppdInstallableConflict` tested too many constraints (Issue #5213)
 - All HTTP field values can now be longer than `HTTP_MAX_VALUE` bytes
   (Issue #5216)

diff --git a/cups/dest-options.c b/cups/dest-options.c
index 18abebf06afe4778f7c7b0e0126ec28bcaffab25..11a1b10fbbbed0a832ae55deb4b0f7b4f6c67fc7 100644 (file)
--- a/cups/dest-options.c
+++ b/cups/dest-options.c
@@ -1,7 +1,7 @@
 /*
  * Destination option/media support for CUPS.
  *
- * Copyright 2012-2017 by Apple Inc.
+ * Copyright 2012-2018 by Apple Inc.
  *
  * Licensed under Apache License v2.0.  See the file "LICENSE" for more information.
  */
@@ -722,6 +722,8 @@ cupsCopyDestInfo(
     */
 
     request = ippNewRequest(IPP_OP_GET_PRINTER_ATTRIBUTES);
+
+    ippSetVersion(request, version / 10, version % 10);
     ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL,
                 uri);
     ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,