Bug 5194: Remove all unused debug sections (#969)

... that we can find quickly.

Naming/documenting debugging sections is a good idea, but that should
not be done in every source code file that relies on that section. We
cannot remove all such DEBUG: declarations without developing a proper
way to name/document sections, but we can (and, given Bug 5194
existence, probably should) remove the unused ones -- their removal does
not remove any immediately usable info.

Bug 5194 report was specific to Section 56: Folks misinterpret section
56 "HTTP Message Body" title as promising to dump message bodies to
cache.log, which is not a functionality that should be driven by a
debugging section. Currently, Squid lacks such functionality.

diff --git a/doc/debug-sections.txt b/doc/debug-sections.txt
index a91351d9ebc333dd754af2d85b2ae5217b1710a3..c3f48fb4896b49b732003c788913e72a460407e7 100644 (file)
--- a/doc/debug-sections.txt
+++ b/doc/debug-sections.txt
@@ -107,17 +107,12 @@ section 53    Radix Tree data structure implementation
 section 54    Interprocess Communication
 section 54    Windows Interprocess Communication
 section 55    HTTP Header
-section 56    HTTP Message Body
 section 57    HTTP Status-line
 section 58    HTTP Reply (Response)
-section 59    auto-growing Memory Buffer with printf
 section 61    Redirector
-section 62    Generic Histogram
-section 63    Low Level Memory Pool Management
 section 64    HTTP Range Header
 section 65    HTTP Cache Control Header
 section 66    HTTP Header Tools
-section 67    String
 section 68    HTTP Content-Range Header
 section 70    Cache Digest
 section 71    Store Digest Manager

diff --git a/src/HttpBody.cc b/src/HttpBody.cc
index adfff9d9f5dda67364a2cc12896d76e4be1e4645..cf5952eaa913d5a5cfa49e00459c03b1ce66e1eb 100644 (file)
--- a/src/HttpBody.cc
+++ b/src/HttpBody.cc
@@ -6,8 +6,6 @@
  * Please see the COPYING and CONTRIBUTORS files for details.
  */
 
-/* DEBUG: section 56    HTTP Message Body */
-
 #include "squid.h"
 #include "base/Packable.h"
 #include "HttpBody.h"

diff --git a/src/MemBuf.cc b/src/MemBuf.cc
index 570eb97192dc62f55e6bf2ced01ec051f3994b47..2b96b83f9d9963fdce99ea0a6950175238ad8d4c 100644 (file)
--- a/src/MemBuf.cc
+++ b/src/MemBuf.cc
@@ -6,8 +6,6 @@
  * Please see the COPYING and CONTRIBUTORS files for details.
  */
 
-/* DEBUG: section 59    auto-growing Memory Buffer with printf */
-
 /**
  \verbatim
  * Rationale:

diff --git a/src/StatHist.cc b/src/StatHist.cc
index 91c999121735a06f4141f37868370854b04e109d..d439106cf63bfe74087834e29e36a8655539eb02 100644 (file)
--- a/src/StatHist.cc
+++ b/src/StatHist.cc
@@ -6,8 +6,6 @@
  * Please see the COPYING and CONTRIBUTORS files for details.
  */
 
-/* DEBUG: section 62    Generic Histogram */
-
 #include "squid.h"
 #include "StatHist.h"
 

diff --git a/src/String.cc b/src/String.cc
index f3805d374c66f51af9224dcbe434b802776dde8a..98b13336a53261acabc9f37a6326e28139e2026c 100644 (file)
--- a/src/String.cc
+++ b/src/String.cc
@@ -6,8 +6,6 @@
  * Please see the COPYING and CONTRIBUTORS files for details.
  */
 
-/* DEBUG: section 67    String */
-
 #include "squid.h"
 #include "base/TextException.h"
 #include "mgr/Registration.h"

diff --git a/src/mem/Pool.cc b/src/mem/Pool.cc
index 566cb2fd25e4599becd30fba27389aebd78f1896..6ec649c538897729b8fe20c61544edb17996e6a5 100644 (file)
--- a/src/mem/Pool.cc
+++ b/src/mem/Pool.cc
@@ -7,7 +7,6 @@
  */
 
 /*
- * DEBUG: section 63    Low Level Memory Pool Management
  * AUTHOR: Alex Rousskov, Andres Kroonmaa, Robert Collins
  */
 

diff --git a/src/mem/PoolChunked.cc b/src/mem/PoolChunked.cc
index 812cbfa5799f66120dabd15a3ab9bb7334186f5c..8e5bc85e2ba7e9f91f888a7a7b3e158a6b52fe92 100644 (file)
--- a/src/mem/PoolChunked.cc
+++ b/src/mem/PoolChunked.cc
@@ -7,7 +7,6 @@
  */
 
 /*
- * DEBUG: section 63    Low Level Memory Pool Management
  * AUTHOR: Alex Rousskov, Andres Kroonmaa, Robert Collins
  */
 

diff --git a/src/mem/PoolMalloc.cc b/src/mem/PoolMalloc.cc
index 2a6ac80f1825da98d4966c015267a1175a5aa221..14a5b7dd393a6620acb9e8b9d7e3ec6a522a95be 100644 (file)
--- a/src/mem/PoolMalloc.cc
+++ b/src/mem/PoolMalloc.cc
@@ -7,7 +7,6 @@
  */
 
 /*
- * DEBUG: section 63    Low Level Memory Pool Management
  * AUTHOR: Alex Rousskov, Andres Kroonmaa, Robert Collins, Henrik Nordstrom
  */