Optimization: DelayId::compositePosition() copied position ptr (#1799)

Detected by Coverity. CID 1529588: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).

diff --git a/src/DelayId.cc b/src/DelayId.cc
index 6143ff806f2161b4265953167978cc3b892f8c0e..91acdb1f9922083e831b3315beb546834646b223 100644 (file)
--- a/src/DelayId.cc
+++ b/src/DelayId.cc
@@ -38,7 +38,7 @@ DelayId::~DelayId ()
 {}
 
 void
-DelayId::compositePosition(DelayIdComposite::Pointer newPosition)
+DelayId::compositePosition(const DelayIdComposite::Pointer &newPosition)
 {
     compositeId = newPosition;
 }

diff --git a/src/DelayId.h b/src/DelayId.h
index 12710c286977088452146896b77c7bd9315acd0a..0ab2c9d874c2ea5a38eb26c6c0ad37a10c051ffe 100644 (file)
--- a/src/DelayId.h
+++ b/src/DelayId.h
@@ -29,7 +29,7 @@ public:
     unsigned short pool() const;
     DelayIdComposite::Pointer compositePosition();
     DelayIdComposite::Pointer const compositePosition() const;
-    void compositePosition(DelayIdComposite::Pointer );
+    void compositePosition(const DelayIdComposite::Pointer &);
     bool operator == (DelayId const &rhs) const;
     operator bool() const;
     int bytesWanted(int min, int max) const;