]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
veritysetup-generator: drop unused struct and variable
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 18 Jan 2021 22:18:45 +0000 (07:18 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 18 Jan 2021 22:21:57 +0000 (07:21 +0900)
Follow-ups for 08b04ec7e72b7327b4803809732b1b8fce8dd069.

This also drops unnecessary inclusion.

Fixes CID#1443889.

src/veritysetup/veritysetup-generator.c

index 9f47a0515a0ed0d3d31316305b02dd5bd6bc5b80..d16d7edebd5a3256c4e7bcc68165929cd0792676 100644 (file)
@@ -7,7 +7,6 @@
 #include <unistd.h>
 
 #include "alloc-util.h"
-#include "dropin.h"
 #include "fd-util.h"
 #include "fileio.h"
 #include "fstab-util.h"
 
 #define SYSTEMD_VERITYSETUP_SERVICE "systemd-veritysetup@root.service"
 
-typedef struct verity_device {
-        char *uuid;
-        char *datadev;
-        char *hashdev;
-        char *roothash;
-        char *name;
-        char *options;
-        bool create;
-} verity_device;
-
 static const char *arg_dest = NULL;
 static bool arg_enabled = true;
 static bool arg_read_veritytab = true;
@@ -395,9 +384,7 @@ static int add_veritytab_devices(void) {
         for (;;) {
                 _cleanup_free_ char *line = NULL, *name = NULL, *data_device = NULL, *hash_device = NULL,
                                     *roothash = NULL, *options = NULL;
-                verity_device *d = NULL;
                 char *l, *data_uuid, *hash_uuid;
-                int k;
 
                 r = read_line(f, LONG_LINE_MAX, &line);
                 if (r < 0)
@@ -411,8 +398,8 @@ static int add_veritytab_devices(void) {
                 if (IN_SET(l[0], 0, '#'))
                         continue;
 
-                k = sscanf(l, "%ms %ms %ms %ms %ms", &name, &data_device, &hash_device, &roothash, &options);
-                if (k < 4 || k > 5) {
+                r = sscanf(l, "%ms %ms %ms %ms %ms", &name, &data_device, &hash_device, &roothash, &options);
+                if (!IN_SET(r, 4, 5)) {
                         log_error("Failed to parse %s:%u, ignoring.", arg_veritytab, veritytab_line);
                         continue;
                 }
@@ -433,9 +420,6 @@ static int add_veritytab_devices(void) {
                                 arg_veritytab);
                 if (r < 0)
                         return r;
-
-                if (d)
-                        d->create = false;
         }
 
         return 0;