]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix expiration of self-signed generated certs to be 3 years (#501)
authorJames DeFelice <james.defelice@gmail.com>
Mon, 28 Oct 2019 10:53:51 +0000 (10:53 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Sat, 2 Nov 2019 23:08:29 +0000 (12:08 +1300)
Generated self-signed certificates lifetime was incorrectly set to
356*3 days, which is approximately 27 days shorter than 3 years.

The fixed problem does not affect Squids using "sslproxy_cert_adapt
setValidAfter" and Squids using a configured signing CA certificate.

src/ssl/gadgets.cc

index 2688513cd7038225bffabe58f96f7aa32ec694a4..92b20a5a01e6c91960abd7b4a8e1520af060bded 100644 (file)
@@ -504,7 +504,7 @@ static bool buildCertificate(Security::CertPointer & cert, Ssl::CertificatePrope
     if (aTime) {
         if (!X509_set1_notAfter(cert.get(), aTime))
             return false;
-    } else if (!X509_gmtime_adj(X509_getm_notAfter(cert.get()), 60*60*24*356*3))
+    } else if (!X509_gmtime_adj(X509_getm_notAfter(cert.get()), 60*60*24*365*3))
         return false;
 
     int addedExtensions = 0;