Remove tui_clear_source_windows_detail

The calls to tui_clear_source_windows_detail in tui_add_win_to_layout
aren't needed, because (after the resize unification) resizing will
update the window contents.  Removing these calls lets us remove
several other things as well.

gdb/ChangeLog
2019-09-20  Tom Tromey  <tom@tromey.com>

	* tui/tui-data.h (tui_clear_source_windows_detail): Don't
	declare.
	* tui/tui-layout.c (tui_add_win_to_layout): Don't call
	tui_clear_source_windows_detail.
	* tui/tui-winsource.h (struct tui_source_window_base)
	<clear_detail>: Don't declare.
	* tui/tui-winsource.c (tui_source_window_base::clear_detail):
	Remove.
	* tui/tui-data.c (tui_clear_source_windows_detail): Remove.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index b1c4db854b41350351e29c68bae541a9d337ef20..bedc073d9c8c92a53e1ea512a0995ec72de22996 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,15 @@
+2019-09-20  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-data.h (tui_clear_source_windows_detail): Don't
+       declare.
+       * tui/tui-layout.c (tui_add_win_to_layout): Don't call
+       tui_clear_source_windows_detail.
+       * tui/tui-winsource.h (struct tui_source_window_base)
+       <clear_detail>: Don't declare.
+       * tui/tui-winsource.c (tui_source_window_base::clear_detail):
+       Remove.
+       * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
+
 2019-09-20  Tom Tromey  <tromey@adacore.com>
 
        PR ada/24919:

diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c
index c11aa43340c37e68dc650199dd9db3142fe910df..833ea49a951131c553d5d14a7793810427cdb637 100644 (file)
--- a/gdb/tui/tui-data.c
+++ b/gdb/tui/tui-data.c
@@ -87,15 +87,6 @@ tui_set_win_with_focus (struct tui_win_info *win_info)
 }
 
 
-/* Clear the pertinent detail in the source windows.  */
-void
-tui_clear_source_windows_detail ()
-{
-  for (tui_source_window_base *win : tui_source_windows ())
-    win->clear_detail ();
-}
-
-
 /* Accessor for the term_height.  */
 int
 tui_term_height (void)

diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 23f769f6ba578e64c82a506784b3d9b6b0aad046..be819503cf277b7b00e075693e816f998286918b 100644 (file)
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -295,7 +295,6 @@ extern void tui_set_term_height_to (int);
 extern int tui_term_width (void);
 extern void tui_set_term_width_to (int);
 extern struct tui_locator_window *tui_locator_win_info_ptr (void);
-extern void tui_clear_source_windows_detail (void);
 extern struct tui_win_info *tui_win_with_focus (void);
 extern void tui_set_win_with_focus (struct tui_win_info *);
 extern int tui_win_resized (void);

diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index df7056ae97b64c5c18f6d9aadd50e38c88a9757b..d331a2f25c73aff68a9c219dc0d590629ccef60d 100644 (file)
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -207,7 +207,6 @@ tui_add_win_to_layout (enum tui_win_type type)
          && cur_layout != SRC_DISASSEM_COMMAND
          && cur_layout != SRC_DATA_COMMAND)
        {
-         tui_clear_source_windows_detail ();
          if (cur_layout == DISASSEM_DATA_COMMAND)
            show_layout (SRC_DATA_COMMAND);
          else
@@ -219,7 +218,6 @@ tui_add_win_to_layout (enum tui_win_type type)
          && cur_layout != SRC_DISASSEM_COMMAND
          && cur_layout != DISASSEM_DATA_COMMAND)
        {
-         tui_clear_source_windows_detail ();
          if (cur_layout == SRC_DATA_COMMAND)
            show_layout (DISASSEM_DATA_COMMAND);
          else

diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c
index 7a4821dc52c7495f94b0d54bd150dba65f00a998..4520a1ac3fea2f080161b931221e641a7fabe4cd 100644 (file)
--- a/gdb/tui/tui-winsource.c
+++ b/gdb/tui/tui-winsource.c
@@ -253,17 +253,6 @@ tui_source_window_base::show_source_content ()
   refresh_window ();
 }
 
-/* See tui-data.h.  */
-
-void
-tui_source_window_base::clear_detail ()
-{
-  gdbarch = NULL;
-  start_line_or_addr.loa = LOA_ADDRESS;
-  start_line_or_addr.u.addr = 0;
-  horizontal_offset = 0;
-}
-
 tui_source_window_base::tui_source_window_base (enum tui_win_type type)
   : tui_win_info (type)
 {

diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index 4c98ca3ceb29cf0d6136e59c3fbdf4e335683cad..445cc7c73572ff1b7a96010d7254728775c885a5 100644 (file)
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -101,8 +101,6 @@ protected:
 
 public:
 
-  void clear_detail ();
-
   /* Refill the source window's source cache and update it.  If this
      is a disassembly window, then just update it.  */
   void refill ();