Initialize EXPR in dtrace-probe::dtrace_process_dof_probe

GCC 4.4.7 generates the following warning:

 | cc1: warnings being treated as errors
 | dtrace-probe.c: In function ‘dtrace_process_dof_probe’:
 | dtrace-probe.c:416: error: ‘expr’ may be used uninitialized in this function
 | make[2]: *** [dtrace-probe.o] Error 1

Later versions (GCC 5) do a better job and don't generate the warning,
but it does not hurt to pre-initialize "expr" to NULL.

gdb/ChangeLog:

        * dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3ef965c9f73c214aa9c631a4276cd0cb96cc83bf..72940b0fc65c146bc2ec4e43446976a3b317978b 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-27  Joel Brobecker  <brobecker@adacore.com>
+
+       * dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL.
+
 2015-03-27  Andrzej Kaczmarek  <andrzej.kaczmarek@tieto.com>
 
        * gdb_bfd.c (gdb_bfd_section_index): Fix off-by-one for special

diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c
index ff7ce7d868f6259e0776f7f0b3decc8cf8a9fada..3f2548ddc4c2796c2e898ceb80639b94c1ed378f 100644 (file)
--- a/gdb/dtrace-probe.c
+++ b/gdb/dtrace-probe.c
@@ -413,7 +413,7 @@ dtrace_process_dof_probe (struct objfile *objfile,
       for (j = 0; j < ret->probe_argc; j++)
        {
          struct dtrace_probe_arg arg;
-         struct expression *expr;
+         struct expression *expr = NULL;
 
          /* Set arg.expr to ensure all fields in expr are initialized and
             the compiler will not warn when arg is used.  */